-
Notifications
You must be signed in to change notification settings - Fork 15
Typescript Implementation #180
base: master
Are you sure you want to change the base?
Conversation
This is now ready for review, however it is not ready to merge. |
Also fixed TokenProvider constructor.
If anyone is interested in helping, there's a few cases where I've used explicit anys in some internal functions. As far as I can tell, I can't type web requests, as the pusher platform doesn't have types for them. But some of the ramda functions can be typed, I've just skipped them because they're not public facing and I don't fully understand them. |
Just wanted to let you know that we've seen this and will take the time to give it a proper look as soon as we get the chance. Looks really promising though, thanks! 😄 |
@Alex-231 thank you for an enormous job you have done! @callum-oakley are you planning to merge this pull request anytime soon? If yes, do you have an ETA? |
Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client |
Thank you @Alex-231, will give it a try. |
Yeah |
This would be great! |
@codieradical: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@codieradical: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pulled the changes to quickly review the conflicts, it's too much for me to do right now. Might get back to this in a month or two. |
Changes
I've added types to all source files in this project, with some small changes to method signatures, and mistypes/unused variables.
Solves #69