Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Typescript Implementation #180

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

craftycodie
Copy link

@craftycodie craftycodie commented Jun 17, 2019

Changes

I've added types to all source files in this project, with some small changes to method signatures, and mistypes/unused variables.

Solves #69

@craftycodie craftycodie marked this pull request as ready for review June 18, 2019 20:22
@craftycodie
Copy link
Author

This is now ready for review, however it is not ready to merge.
I would like some guidance regarding @pusher's typescript configuration preferences, and general feedback would be great too.

@craftycodie
Copy link
Author

If anyone is interested in helping, there's a few cases where I've used explicit anys in some internal functions. As far as I can tell, I can't type web requests, as the pusher platform doesn't have types for them. But some of the ramda functions can be typed, I've just skipped them because they're not public facing and I don't fully understand them.

@callum-oakley
Copy link
Contributor

Just wanted to let you know that we've seen this and will take the time to give it a proper look as soon as we get the chance. Looks really promising though, thanks! 😄

@MaratFM
Copy link

MaratFM commented Jul 10, 2019

@Alex-231 thank you for an enormous job you have done!

@callum-oakley are you planning to merge this pull request anytime soon? If yes, do you have an ETA?
This PR is very important for us, we are evaluating multiple chat solutions right now. Not having typings could be a deal-breaker.

@craftycodie
Copy link
Author

@Alex-231 thank you for an enormous job you have done!

@callum-oakley are you planning to merge this pull request anytime soon? If yes, do you have an ETA?
This PR is very important for us, we are evaluating multiple chat solutions right now. Not having typings could be a deal-breaker.

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

@MaratFM
Copy link

MaratFM commented Jul 10, 2019

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

Thank you @Alex-231, will give it a try.
Did you generate typings from the code in this pull request?

@craftycodie
Copy link
Author

Thanks for your interest, I imagine merging this will be a bit of a job now considering master has been updated to the v6 api. However in the mean time you could use these type definitions. https://github.com/Alex-231/types_pusher__chatkit-client

Thank you @Alex-231, will give it a try.
Did you generate typings from the code in this pull request?

Yeah

@stfny222
Copy link

This would be great!

@pusher-ci
Copy link

@codieradical: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@pusher-ci
Copy link

@codieradical: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@craftycodie
Copy link
Author

Pulled the changes to quickly review the conflicts, it's too much for me to do right now. Might get back to this in a month or two.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants