Honor receive message completion - #69
Open
mike-at-legend wants to merge 1 commit into
Open
Conversation
mike-at-legend
marked this pull request as ready for review
August 10, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
isCompletevalue fromNWConnection.receiveMessage.Why
The receive loop ignored
isCompleteand sent non-empty data to the delegate before it handled a transport error.NWConnectioncan return partial data withisComplete == falsewhen a receive ends with an error. A text delegate could receive that partial data as a complete UTF-8 or JSON message.The error path does not change. It still reports the transport failure and stops the receive loop.
Impact
Clients no longer receive incomplete WebSocket data as a complete message.
Validation
swift testFixes #68.