Skip to content

Switch to mautrix-go - #38

Merged
eikendev merged 11 commits into
mainfrom
#24-switch-to-mautrix
Mar 13, 2022
Merged

eikendev merged 11 commits into
mainfrom
#24-switch-to-mautrix

Conversation

@CubicrootXYZ

Copy link
Copy Markdown
Collaborator

In order to get more features (e.g. encryption #24) switch from the default matrix go library to mautrix-go.

@CubicrootXYZ CubicrootXYZ added the enhancement New feature or request label Feb 9, 2022
@CubicrootXYZ
CubicrootXYZ marked this pull request as draft February 9, 2022 19:20
@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

Code wise the work is done, needs testing now.

@eikendev eikendev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks a lot simpler that I had imagined; good job. What kind of testing do you mean, function tests or manual testing?

Comment thread internal/dispatcher/application.go Outdated
Comment thread internal/dispatcher/dispatcher.go Outdated
Comment thread internal/dispatcher/notification.go Outdated
Comment thread internal/dispatcher/notification.go Outdated
@CubicrootXYZ
CubicrootXYZ marked this pull request as ready for review February 11, 2022 21:12
@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

Wow, this looks a lot simpler that I had imagined; good job. What kind of testing do you mean, function tests or manual testing?

Manual testing if everything still works, did not do that yesterday but did it now.

Comment thread internal/authentication/token.go
@eikendev eikendev mentioned this pull request Feb 11, 2022
@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

matrix.org seems to have some trouble currently, will try testing it later again.

@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

Digging deeper I think the issue is that the session from the bot is not verified and therefore the clients from other users will ignore any event sent to them.

@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

Everything working fine - somehow my bot got on the ignored list, my bad. Tested it and it is working just fine.

@eikendev

eikendev commented Mar 6, 2022

Copy link
Copy Markdown
Member

Thanks for rebasing, I'll take a look this week!

@eikendev eikendev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this, just want to clarify some minor things.

Comment thread go.mod Outdated
Comment thread internal/dispatcher/dispatcher.go Outdated
Comment thread internal/dispatcher/notification.go
@eikendev

Copy link
Copy Markdown
Member

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

@CubicrootXYZ

Copy link
Copy Markdown
Collaborator Author

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

yes, it is.

@eikendev
eikendev merged commit 54bc389 into main Mar 13, 2022
@eikendev
eikendev deleted the #24-switch-to-mautrix branch March 13, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants