fix: IOS native review bad UX experience

[regevbr]

fix: #279
fix: #278
fix: #267

@westonganger can you please review?

[westonganger]

If InAppBrowser does NOT work for iOS

Your saying InAppBrowser doesnt work for iOS? If so lets not include that option. We can simply default to the native app store review if inAppReview: false , no need to add another option for nativeAppReview

If InAppBrowser does work on iOS
Rather than adding another option why dont we unify them:

iosReviewType: 'AppStoreReview' // default
iosReviewType: 'InAppReview'
iosReviewType: 'InAppBrowser'

[regevbr]

@westonganger thanks for your response.
I can't be sure completely if InAppBrowser will not work, but I'm fairly certain WKWebview won't work. Some might still use UIWebview and maybe there it will work. Debugging this is very hard as simulator and test flight act strange when it comes to reviewing logic.
My proposed changes are backward compatible and I think they should remain as such. If you want to release a new major version I can make the suggested breaking change:

iosReviewType: 'AppStoreReview' // default
iosReviewType: 'InAppReview'
iosReviewType: 'InAppBrowser'

Thoughts?

[westonganger]

Maybe to future proof this we should change the syntax to:

reviewType: {
  ios: 'AppStoreReview', // default
  ios: 'InAppReview',
  ios: 'InAppBrowser',
}

Please implement the above if you agree.

[regevbr]

sounds perfect will submit it soon

[westonganger]

Please also add the following additions to the PR:

• changelog entry
• typescript typings

[regevbr]

@westonganger Already fixed typescript defentiions. About the change log, what is the version you want to give?

[westonganger]

Sorry I usually leave a section like the following:

• Unreleased
  • Nothing yet

Please use "Unreleased"

[regevbr]

Done please review

[westonganger]

Please fix the indentation in www/AppRate.js and if possible can you rebase to 1 commit? Ex. git rebase -i

Also please change the first changelog entry to:

Removed iOS option `inAppReview` in favor of new option `reviewType`. Please update your app according to the updated documentation.

[regevbr]

Done. The indent issues were because I use tabs and in my display, they are equal to 2 spaces :-)

[westonganger]

Awesome great work. Merged. Thanks for your contribution!

[regevbr]

Thanks for helping with getting the fix through fast!
When can we expect a new version?

[westonganger]

Maybe in about a month. I like to let things percolate for a time before releasing.

[regevbr]

Ok I'll will update my plugin directly from github. Can you let me know why you need that time to wait? No one (well besides me) will be able to give feedback of the changes if they are not released and used...