Skip to content

Conversation

@vaclavGabriel
Copy link

@vaclavGabriel vaclavGabriel commented Jan 26, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed tab indicator not updating correctly when tabs or tab references change unexpectedly.

✏️ Tip: You can customize this high-level summary in your review settings.

@linear
Copy link

linear bot commented Jan 26, 2026

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

Updated the useEffect dependency array in ActiveTabIndicator.tsx by adding tabs and tabRefs dependencies, causing the effect to re-run when these values change. This addresses incorrect tab underline positioning after language changes.

Changes

Cohort / File(s) Summary
Bug Fix - Dependency Array Update
src/components/Tabs/ActiveTabIndicator.tsx
Expanded useEffect dependency array from [selectedIndex] to [selectedIndex, tabs, tabRefs] to ensure the indicator recalculates position when tab references or tab data changes, fixing underline length issues after language switching
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the issue identifier (FX-1398) and accurately describes the main bug being fixed: incorrect underline length for Individual/Corporate tabs.
Linked Issues check ✅ Passed The code change (expanding useEffect dependencies) directly addresses the root cause of the bug by ensuring the indicator recalculates when tabs or their refs change after language switching.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the ActiveTabIndicator component's dependency array, directly addressing the language-switch bug with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vaclavGabriel
Copy link
Author

Before and after
image

@vaclavGabriel vaclavGabriel requested review from PetrHendrych97 and samuelg0rd0n and removed request for PetrHendrych97 and samuelg0rd0n January 26, 2026 10:10
@vaclavGabriel
Copy link
Author

Tabs will be cancelled as a part of the axiory redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants