Chart icon fix and enhancements #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed icon url - Added `keywords` and `maintainers` attributes
sdodsley
reviewed
Mar 29, 2019
pure-k8s-plugin/Chart.yaml
Outdated
| @@ -1,6 +1,11 @@ | |||
| apiVersion: v1 | |||
| description: A Helm chart for Pure Storage persistent storage driver for Kubernetes/OpenShift | |||
| name: pure-k8s-plugin | |||
| version: 2.3.1 | |||
| version: 2.3.2 | |||
There was a problem hiding this comment.
I don't think we should be changing these release numbers in PRs. This should be down to the release process to pick the correct release number this PR goes into.
Agree with @sdodsley. I don't know what the versioning policy is whenever a PR changes the chart (but not the code) and I'm completely fine keeping the current release version.
dinathom
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keywordsandmaintainersattributes