Conditionally install daemonset to configure nodes in GKE. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdodsley
requested changes
Feb 3, 2020
…set invokes a script from the PSO image that is responsible for preparing GKE nodes for use. At the time of writing this includes installing open-iscsi and multipath-tools as well as configuring and enabling iscsid. Conditionally disable csi-snapshotter in GKE. A requirement for Anthos is that we do not enable any alpha features.
|
I resolved the conversations that were in flight, please holler if I didn't resolve your concerns. |
sdodsley
approved these changes
Feb 4, 2020
trevormeiss
approved these changes
Feb 4, 2020
caryli-ps
approved these changes
Feb 4, 2020
|
Wow ! 3 approvers ... thanks a lot ! |
|
Since this PR is approved, and its dependent PR (https://github.dev.purestorage.com/pso/k8s/pull/162) is also merged in .... going ahead with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The daemonset invokes a script from the PSO image that is responsible for preparing GKE nodes for use. At the time of writing this includes installing open-iscsi and multipath-tools
as well as configuring and enabling iscsid.
Conditionally disable csi-snapshotter in GKE. A requirement for Anthos is that we do not enable any alpha features.
This PR depends on https://github.dev.purestorage.com/pso/k8s/pull/162
Together, this enables installation of PSO on Google Anthos and satisfies Google's tests for GKE 1.2.1.