Prepare 1.0 version #1375
Open
Prepare 1.0 version #1375
+91
−910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| git tag "${NEW_TAG}" | ||
| # npm version: | ||
| # 1. Updates package.json | ||
| # 2. Runs the "version" script (syncs version to spago.yaml files) |
Member
There was a problem hiding this comment.
Is this guaranteed not to use a v prefix? Otherwise it looks like the scripts could get into a mismatch with a v prefixed version number and a non-prefixed one. Should we add --tag-version-prefix "" so the tag format is explicitly just numeric, regardless of what the npm config setting is where this is run?
Member
There was a problem hiding this comment.
I was thinking about it because I think npm defaults to v being included when you use npm version, for example the genesis of this thread:
https://stackoverflow.com/questions/37788907/have-npm-version-not-prepend-v-to-the-git-tag
Member
Author
There was a problem hiding this comment.
Oh, great catch!! I completely forgot about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the release script, the CI (well, hopefully) and docs so that we are ready for Friday's release.