-
Notifications
You must be signed in to change notification settings - Fork 79
Update to spago 0.93.44 and Nixpkgs 25.5 #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If I remember correctly it’s because of the lock file format changing. It may be a bigger patch than you expect to update Spago 😄 I was thinking we could switch to jeslie’s Spago builder going forward. |
@thomashoneyman I did switch to jeslie0's build machinery and it works (things are good on my machine and CI seems happy) There is only one gotcha, which is that it does something to the |
@toastal curious if you have any thoughts here. I can try and get a review in over the next day or so, but I’m traveling so if you want to merge I am OK with it as-is. |
# I suspect this is because of a quirky interaction between Nix and `copyFile`, | ||
# but I'm not sure how to fix it so we work around it by copying the foreign | ||
# modules by hand. | ||
for dir in output/*/; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not something like find output -type d -maxdepth 1 -print0 | xargs -0 -P$NIX_BUILD_CORES -I{} …
? Could be a bit quicker to run this in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't parse that command - do you have a more precise suggestion? I'm happy with the for loop because it's very readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you did edit in a runnable command, I must have seen an outdated version. That works just as well, but I'd still prefer the for loop
Other than the side quest of possibly removing either @thomashoneyman Tho ever since the PureScript community moved to Discord, I haven’t actively been following the project in my recreational time (nor have I had any work in it in recent years) so I don’t really know what has been going on with any of the tooling. If there were some PS work, I would probably be more aware of what is happening & trying to pitch in. Footnotes
|
The tooling development still happens on the registry-dev and spago repositories so it's in the open (very little is discussed on Discord). No worries about following along — just thought you might have some Nix ideas to contribute, as you had done a nice rework of the package a little while ago! Alas, I no longer work professionally in PureScript myself. |
I forgot why we need to be stuck on Spago 0.93.19, so here's a PR to see what CI thinks of it.
We changed the way test dependencies are included, so I had to separate the test utilities into their own package. Otherwise it should be a pretty boring patch.