Skip to content

Erase elaborated kinds from all errors by default #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

kl0tl
Copy link
Member

@kl0tl kl0tl commented Feb 3, 2021

Description of the change

Nate noticed that NoInstanceFound errors were showing kind applications, which are supposed to be erased in error messages (not hints) unless with --verbose-errors, because they are directly rendered with typeAtomAsBox instead of with something similar to prettyType.

This pull request replaces all occurrences of typeAtomAsBox prettyDepth, except in hints, with a prettyTypeAtom function which erase kind applications as prettyType does.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@hdgarrood
Copy link
Contributor

Shall we merge the release notes PR first and then add this to the list of PRs for polykinds in the release notes then?

@JordanMartinez
Copy link
Contributor

Shall we merge the release notes PR first and then add this to the list of PRs for polykinds in the release notes then?

Sounds sensible to me.

@kl0tl kl0tl force-pushed the no-kind-applications-in-errors branch from 88bce0b to 0e7cc06 Compare February 17, 2021 21:00
@kl0tl kl0tl merged commit 337e803 into purescript:master Feb 17, 2021
@kl0tl kl0tl deleted the no-kind-applications-in-errors branch February 17, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants