Update CONTRIBUTING.md #3924
Merged
Update CONTRIBUTING.md #3924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Link to governance doc where appropriate * Remove reference to core-tests (which no longer exist) * Try to set expectations a bit better re: approving proposals or merging PRs * Rearrange the sections a little for clarity * Mention the `make` task so that it's easier to regenerate the LICENSE file
garyb
approved these changes
Aug 31, 2020
milesfrain
reviewed
Oct 31, 2020
Comment on lines
+54
to
+55
| [the #purescript channel in FP Slack]: https://functionalprogramming.slack.com/ | ||
| [Discourse]: https://discourse.purescript.org/ |
There was a problem hiding this comment.
Are these two lines supposed to be here? They don't appear in the rendered markdown.
There was a problem hiding this comment.
Yes: they allow you to write e.g. [the #purescript channel in FP Slack][] anywhere in the doc without having to have the link destination inline. Removing them would break the links earlier up in the doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging PRs
maketask so that it's easier to regenerate the LICENSEfile
@rhendric was asking me about this just now and I thought it would be a good opportunity to have this written down somewhere people can see it, as well as give this file a much-needed update.