Skip to content

RowList operations #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2017
Merged

RowList operations #15

merged 1 commit into from
Oct 3, 2017

Conversation

LiamGoodacre
Copy link
Member

Building up a collection of RowList operations. PR for discussion.

@MonoidMusician
Copy link

Do you want to add a UnionNub kind of thing for properly typing merge? (as in RowUnion.purs, which should be left-biased unique but only has a Union constraint which creates duplicates)

Here's a naïve implementation (left-biased):

class UnionNub
  (a :: # Type)
  (b :: # Type)
  (c :: # Type)
  | -> a b c
instance unionNub ::
  ( Union a b r
  , RowToList r rl
  , ListToRow rl r
  , RowListNub rl cl
  , ListToRow cl c
  ) => UnionNub a b c

I could probably draft up intersection and difference too.

@justinwoo
Copy link
Contributor

Could this go in sometime so I can depend on it? 😄 I need to use the RowAppend class the most

@paf31
Copy link
Contributor

paf31 commented Aug 31, 2017

I'm happy to merge this whenever @LiamGoodacre says it's good to go.

* RowListRemove
* RowListSet
* RowListNub
* RowListAppend
@LiamGoodacre
Copy link
Member Author

Sorry, I completely forgot about this.

@LiamGoodacre LiamGoodacre changed the title WIP RowList operations RowList operations Oct 3, 2017
@LiamGoodacre
Copy link
Member Author

I'll merge once Travis is happy.

@LiamGoodacre LiamGoodacre merged commit f7385cc into purescript:master Oct 3, 2017
@LiamGoodacre
Copy link
Member Author

@paf31 do you want to make a v2.4.1 for this?

@LiamGoodacre LiamGoodacre deleted the feature/rowlist-ops branch October 3, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants