Update changelog since v5.1.0 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -5,20 +5,26 @@ Notable changes to this project are documented in this file. The format is based | |||
| ## [Unreleased] | |||
|
|
|||
| Breaking changes: | |||
| - Added support for PureScript 0.14 and dropped support for all previous versions (#37, #43) | |||
| - Added `foldr1` and `foldl` implementations to `Foldable1 (Tuple a)` instance and removed `foldl1` (#39, #43) | |||
There was a problem hiding this comment.
I don't think this is a breaking change.
There was a problem hiding this comment.
Move it down to 'Other Improvements' similar to what Miles did in another PR?
There was a problem hiding this comment.
I wasn't sure where to put this; it's changed because the Foldable1 class has changed, and if we were to upgrade the dependency and apply this change in the library in normal circumstances it would be breaking. (For example, you could no longer use fold1 via the class.)
But since it's part of adding support for 0.14, perhaps "other improvements" is the way to go for this particular case.
There was a problem hiding this comment.
I've moved it to "other improvements" for the time being.
| @@ -5,20 +5,26 @@ Notable changes to this project are documented in this file. The format is based | |||
| ## [Unreleased] | |||
|
|
|||
| Breaking changes: | |||
| - Added support for PureScript 0.14 and dropped support for all previous versions (#37, #43) | |||
| - Added `foldr1` and `foldl` implementations to `Foldable1 (Tuple a)` instance and removed `foldl1` (#39, #43) | |||
|
|
|||
| New features: | |||
JordanMartinez
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the CHANGELOG in preparation for the upcoming release of this library.
Related: purescript/purescript#3985