Skip to content

fix runListT #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 30, 2017
Merged

fix runListT #89

merged 7 commits into from
Mar 30, 2017

Conversation

matthewleon
Copy link
Contributor

Addresses #83

Following @kozak's suggestion, this exports runListT with the type forall f a. Monad f => ListT f a -> f Unit.

It also adds some instructive examples of its use to the tests.

matthewleon added a commit to matthewleon/purescript-transformers that referenced this pull request Mar 23, 2017
Addresses purescript#83.

Independent of PR purescript#89.

This brings ListT into line with the other transformers.
matthewleon added a commit to matthewleon/purescript-transformers that referenced this pull request Mar 23, 2017
Addresses purescript#83.

Independent of PR purescript#89.

This brings ListT into line with the other transformers.
@garyb
Copy link
Member

garyb commented Mar 26, 2017

@paf31 any comments here?

@paf31
Copy link
Contributor

paf31 commented Mar 26, 2017

I feel like this could use MonadRec. Let's leave this out for now since it's non-breaking.

@matthewleon matthewleon force-pushed the smart-runListT branch 2 times, most recently from d6dade7 to a34bb6b Compare March 27, 2017 18:17
@matthewleon
Copy link
Contributor Author

@paf31 it would appear that foldl itself could use MonadRec, no? I'm taking a look at this.

@matthewleon
Copy link
Contributor Author

related: #93

@matthewleon
Copy link
Contributor Author

This is now rebased on #93, to export a stack-safe runListTRec. Ready for review.

@matthewleon
Copy link
Contributor Author

Rebased on master.

@paf31 paf31 merged commit cc045ea into purescript:master Mar 30, 2017
@paf31
Copy link
Contributor

paf31 commented Mar 30, 2017

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants