Add bracket #85
Merged
Add bracket #85
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I wonder if there's a better name. I know Haskell uses |
|
Yeah perhaps 😂 I like that name.
Sent from my iPhone.
… Op 10 feb. 2017 om 22:53 heeft Phil Freeman ***@***.***> het volgende geschreven:
Looks good, but I wonder if there's a better name. I know Haskell uses bracket, but it's not great IMO. What about withResource?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
👍 Looks good to me, thanks! |
paf31
reviewed
Feb 16, 2017
src/Control/Monad/Error/Class.purs
Outdated
| -- | release action is called regardless of whether the body action throws or | ||
| -- | returns. | ||
| withResource | ||
| :: ∀ e m r a |
paf31
reviewed
Feb 16, 2017
src/Control/Monad/Error/Class.purs
Outdated
| -- | returns. | ||
| withResource | ||
| :: ∀ e m r a | ||
| . (MonadError e m) |
|
@paf31 Any more comments on this? |
|
@rightfold It looks good, thanks. I have a mountain of PRs to merge, but we'll get them merged before the next major releases (which will coincide with 0.11). |
|
Actually, no reason this can't go in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.