-
Notifications
You must be signed in to change notification settings - Fork 43
Error.Class: add convenice lifting functions #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error.Class: add convenice lifting functions #140
Conversation
cdcd375
to
ff1dc48
Compare
I can see why you'd want to use this, but I don't see why it should be merged into this library. Is there a precedent for this elsewhere? |
@JordanMartinez Thanks for taking a look. Haskell's MTL does provide liftEither for lifting |
@hexagonal-sun Thanks for clarifying! In that case, I think it makes sense to add the I don't think we should add an infix for |
ff1dc48
to
8ef85dc
Compare
@JordanMartinez Great! No problem, I've removed those functions. |
What do y'all think of |
I’m thinking more of the liftEffect, liftAff variety in this case, though you’re right that we do sometimes use the suffix. |
Since Haskell uses |
I think the M suffix is only appropriate when there already exists a version of the function without the suffix, which is less monad-y. |
Add functions that allow `Either` and `Maybe` to be easily lifted to a MonadThrow monad.
8ef85dc
to
fa452d4
Compare
Agreed. I've changed the function names as discussed. |
If this could get merged, that would be great! Thanks. |
Thanks for the reminder! |
Add functions that allow
Either
andMaybe
to be easily lifted to aMonadThrow monad.
Checklist: