Skip to content

Use coerce instead of unsafeCoerce where appropriate #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 26, 2020
Merged

Use coerce instead of unsafeCoerce where appropriate #130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91c8aa3
Replace unsafeCoerce with safer alternative where possible
JordanMartinez Nov 17, 2020
a0423b3
Remove unused import
JordanMartinez Nov 17, 2020
3fdf060
Add docs to the Internal module and NonEmptyString constructor
JordanMartinez Nov 18, 2020
0157801
Remove 'usage of this constructor...' sentence
JordanMartinez Nov 26, 2020
c0be958
Move constructor docs to type docs
JordanMartinez Nov 26, 2020
9dcca40
Add backticks around NonEmptyString in docs
JordanMartinez Nov 26, 2020
036e260
Add "For internal use only. Do not export" above to/fromNEString & listS
JordanMartinez Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add "For internal use only. Do not export" above to/fromNEString & listS
  • Loading branch information
@JordanMartinez
JordanMartinez committed Nov 26, 2020
commit 036e260b3d255fb740936bfc9e10ab472e365c5e
3 changes: 3 additions & 0 deletions src/Data/String/NonEmpty/CodePoints.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,15 @@ import Data.String.NonEmpty.Internal (NonEmptyString(..), fromString)
import Data.String.Pattern (Pattern)
import Partial.Unsafe (unsafePartial)

-- For internal use only. Do not export.
toNonEmptyString :: String -> NonEmptyString
toNonEmptyString = NonEmptyString

-- For internal use only. Do not export.
fromNonEmptyString :: NonEmptyString -> String
fromNonEmptyString (NonEmptyString s) = s

-- For internal use only. Do not export.
liftS :: forall r. (String -> r) -> NonEmptyString -> r
liftS f (NonEmptyString s) = f s

Expand Down
3 changes: 3 additions & 0 deletions src/Data/String/NonEmpty/CodeUnits.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,15 @@ import Data.String.Unsafe as U
import Partial.Unsafe (unsafePartial)
import Unsafe.Coerce (unsafeCoerce)

-- For internal use only. Do not export.
toNonEmptyString :: String -> NonEmptyString
toNonEmptyString = NonEmptyString

-- For internal use only. Do not export.
fromNonEmptyString :: NonEmptyString -> String
fromNonEmptyString (NonEmptyString s) = s

-- For internal use only. Do not export.
liftS :: forall r. (String -> r) -> NonEmptyString -> r
liftS f (NonEmptyString s) = f s

Expand Down