Skip to content

add rename and Builder.rename #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Conversation

justinwoo
Copy link
Contributor

Fixes #17

@MonoidMusician
Copy link

would it be more efficient to use the builder method to implement the regular method? I think that would avoid one copying of the record, something like rename prev next = Builder.build (Builder.rename prev next) ...

@justinwoo
Copy link
Contributor Author

Somehow I still like the pure versions a lot more than the builder versions though

@paf31 paf31 merged commit b337e06 into purescript:master Nov 15, 2017
@paf31
Copy link
Contributor

paf31 commented Nov 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants