Make GenState a newtype and Add Instance for (Testable prop) => Testable (Gen prop) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,7 @@ | |||
| "purescript-lists": "^0.7.0", | |||
| "purescript-random": "^0.2.0", | |||
| "purescript-strings": "^0.7.0", | |||
| "purescript-transformers": "^0.8.1" | |||
| "purescript-transformers": "^0.8.1", | |||
| "purescript-lens": "~0.9.0" | |||
There was a problem hiding this comment.
Lens isn't in the core library set, and relatively infrequently updated AFAIK, so I'd prefer not to add it as a dependency here.
|
This looks good to me. Could you please rebase it against current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows defining the instance discussed in #45. It seemed more convenient to make
GenStateanewtyperather thanGenitself as it avoided having to redefine instances (whereMonadState GenState Genwould not be possible with theGenStatetype synonym).I'm not sure how much breakage this change would cause in other libraries.