Skip to content

Generate CHANGELOG.md file using notes from previous GH releases #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Generate CHANGELOG.md file using notes from previous GH releases #252

merged 3 commits into from
Jan 9, 2021

Conversation

JordanMartinez
Copy link
Contributor

No description provided.


**Breaking changes**
- Fixed `=<<` to be right associative, as originally intended
- Changed behaviour of `Eq` and `Ord` for `NaN` numeric value #91 (@berdario)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, unlike the GitHub releases, the raw CHANGELOG readme won't link things like #91 for pull requests and @berdario for GitHub user profiles.

We can choose to fix these (increasing the workload) or leave them as-is (if required, folks can go look up the pull request or user profile themselves) or decide not to track them (removing these references -- I think this would be losing valuable information).

My gut sense is that we probably should accept that changelogs pre-0.14 should be treated as-is, and we simply try to use the standard format (breaking changes / new features / bugfixes / other) with proper links going forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW in Spago we use the same format, and I think it's valuable to track this info even if it's not directly linking. I think there's actually value in leaving such links out, because it makes maintaining the changelog less burdensome (I'd say lowering the treshold to keep this up to date is key here), and the raw file (i.e. when you're not looking at a markdown render) stays readable.

Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice translation of the GitHub releases into a format we can use to have good changelog files for these libraries going forward.

I don't think it's worth the effort to comb through each changelog to switch it to the breaking / new features / bugfixes / other improvements format, or to fix links and references. Instead, I think it's better to just have the concrete CHANGELOG files in the first place and enforce formatting going forward.

@thomashoneyman
Copy link
Member

thomashoneyman commented Jan 6, 2021

Another thing worth noting: in the contrib libraries we also have a pull request template which includes a checklist item reminding the pull request author to add their changes to the CHANGELOG. That way we distribute the work of keeping this file up-to-date and ready to use when it comes time to make a proper release.

See: https://github.com/purescript-contrib/purescript-machines/blob/main/.github/PULL_REQUEST_TEMPLATE.md

I think that we should add this template (or a similar one) at the same time that we add CHANGELOG files.

@JordanMartinez
Copy link
Contributor Author

Adding a PULL_REQUEST_TEMPLATE.md sounds good to me. But again, I'd rather we agree what that template file should be before submitting PRs, so that we don't have to fix it again in another round of PRs.

@thomashoneyman
Copy link
Member

Yea. I would also like weigh-in from other core members. But I suggest that if we do add these CHANGELOG.md files that we also add a pull request template which requests that pull request authors also update the changelog. For context, the template file which is used across the contrib organization lives here:

https://github.com/purescript-contrib/governance/blob/main/updater/templates/base/.github/PULL_REQUEST_TEMPLATE.md

@JordanMartinez
Copy link
Contributor Author

I've added the pull request template here. Once we get feedback from other core contributors, I'd like to update my script to copy this across all core libraries.

@JordanMartinez JordanMartinez merged commit b01753f into purescript:master Jan 9, 2021
@JordanMartinez JordanMartinez deleted the addChangelog branch January 9, 2021 02:09
turlando pushed a commit to purescm/purescript-prelude that referenced this pull request Sep 3, 2021
…escript#252)

* Generate CHANGELOG.md file using notes from previous GH releases

* Add pull request template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants