Fix loop #233
Merged
Fix loop #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Oct 11, 2020
src/Control/Monad.purs
Outdated
| @@ -64,3 +65,22 @@ unlessM :: forall m. Monad m => m Boolean -> m Unit -> m Unit | |||
| unlessM mb m = do | |||
| b <- mb | |||
| unless b m | |||
|
|
|||
| -- | `ap` provides a default implementation of `(<*>)` for any `Bind`, without | |||
There was a problem hiding this comment.
Forgot to update that.
hdgarrood
reviewed
Oct 11, 2020
src/Control/Monad.purs
Outdated
| @@ -64,3 +65,22 @@ unlessM :: forall m. Monad m => m Boolean -> m Unit -> m Unit | |||
| unlessM mb m = do | |||
| b <- mb | |||
| unless b m | |||
|
|
|||
| -- | `ap` provides a default implementation of `(<*>)` for any `Monad`, without | |||
| -- | using `(<*>)` as provided by the `Apply`-`Bind` superclass relationship. | |||
There was a problem hiding this comment.
Why? Isn't this specifically referring to Apply and Bind? Not Apply and Monad?
There was a problem hiding this comment.
Because this function has a Monad constraint. It's saying that while you could implement ap by just writing ap = apply (since the function has a Monad constraint, and Apply is one of Monad's superclasses), we don't, because we want people to be able to write apply = ap in their Apply instances.
There was a problem hiding this comment.
Ah, thanks for clarifying.
There was a problem hiding this comment.
I've fixed that in latest commits.
hdgarrood
approved these changes
Oct 11, 2020
4 tasks
turlando
pushed a commit
to purescm/purescript-prelude
that referenced
this pull request
Sep 3, 2021
* Update Apply superclass law * Change ap constraint back to Monad * Port `ap` back to Monad * Reimplement `ap` using bind and pure * Document why revert was needed * Stop importing ap from Bind * Update purescript-psa to v0.8.0 * Update "for any Bind" to "for any Monad" * Update 'Apply - Bind' to 'Apply - Monad'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232