Speed up keys by using foldrWithIndex

CHANGELOG.md

@@ -10,7 +10,7 @@ Breaking changes:
 New features:
 - Exported `Data.Map.Internal` data constructors (#52 by @natefaubion)
 - Add unbiased `Semigroup`/`Monoid` instances to `Map` with `Warn` (#54 by @JordanMartinez)
-- Improved speed of `foldr`, `foldl`, `foldMap`, `foldlWithIndex`, `foldrWithIndex`, `foldMapWithIndex`, `unionWith`, and `values` (#60 by @xgrommx, #61 by @JordanMartinez)
+- Improved speed of `foldr`, `foldl`, `foldMap`, `foldlWithIndex`, `foldrWithIndex`, `foldMapWithIndex`, `unionWith`, `keys` and `values` (#60 by @xgrommx, #61 and #62 by @JordanMartinez)
 
 Bugfixes:
 

bench/Bench/Data/Map.purs

@@ -42,6 +42,12 @@ benchMap = do
   log "---------------"
   benchValues
 
+  log ""
+
+  log "keys"
+  log "---------------"
+  benchKeys
+
   where
 
   benchUnion = do
@@ -76,6 +82,20 @@ benchMap = do
     log $ "M.values: big map (" <> show size' <> ")"
     benchWith 10 \_ -> M.values bigMap'
 
+  benchKeys = do
+    let nats = L.range 0 999999
+        natPairs = (flip Tuple) unit <$> nats
+        bigMap = Map2a0bff.fromFoldable $ natPairs
+        bigMap' = M.fromFoldable $ natPairs
+        size = Map2a0bff.size bigMap
+        size' = M.size bigMap'
+
+    log $ "Map2a0bff.keys: big map (" <> show size <> ")"
+    benchWith 10 \_ -> Map2a0bff.keys bigMap
+
+    log $ "M.keys: big map (" <> show size' <> ")"
+    benchWith 10 \_ -> M.keys bigMap'
+
   benchSize = do
     let nats = L.range 0 999999
         natPairs = (flip Tuple) unit <$> nats

src/Data/Map/Internal.purs

@@ -651,9 +651,7 @@ toUnfoldableUnordered m = unfoldr go (m : Nil) where
 
 -- | Get a list of the keys contained in a map
 keys :: forall k v. Map k v -> List k
-keys Leaf = Nil
-keys (Two left k _ right) = keys left <> pure k <> keys right
-keys (Three left k1 _ mid k2 _ right) = keys left <> pure k1 <> keys mid <> pure k2 <> keys right
+keys = foldrWithIndex (\k _ acc -> k : acc) Nil
 
 -- | Get a list of the values contained in a map
 values :: forall k v. Map k v -> List v