Skip to content

Avoid exporting unsafeThrow from Data.Maybe.Unsafe #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hdgarrood
Copy link
Contributor

No description provided.

@paf31
Copy link
Contributor

paf31 commented Jan 13, 2016

Breaking change, technically, but looks good, thanks.

@garyb
Copy link
Member

garyb commented Jan 13, 2016

Yeah, I have a feeling that this might be used elsewhere 😞

We'll be able to remove this anyway in 0.8 since they'll gain Partial constraints instead (I assume?)

@Thimoteus
Copy link
Contributor

There's also unsafeThrow from purescript-exceptions. It's strange to see the same function in a Maybe library.

@hdgarrood
Copy link
Contributor Author

It was an oversight (mine) that this was ever exported, yeah.

@hdgarrood
Copy link
Contributor Author

close this in favour of #20?

@garyb
Copy link
Member

garyb commented Feb 27, 2016

👍

@hdgarrood hdgarrood closed this Feb 27, 2016
@hdgarrood hdgarrood deleted the unexport-unsafethrow branch February 27, 2016 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants