Make elements test no longer hang at cost of possible false negative
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
reviewed
Nov 16, 2020
test/Main.purs
Outdated
| -- implement a Set-like value without depending on ordered-collections | ||
| -- because that library depends on this one. | ||
| addElemIfNew arr e = if Array.elem e arr then arr else Array.snoc arr e | ||
| actualElems = Array.sort $ foldl addElemIfNew [] elems |
There was a problem hiding this comment.
Could just use nub + sort of elems? 🙂
There was a problem hiding this comment.
Yeah, that's a lot better. Thanks!
thomashoneyman
approved these changes
Dec 5, 2020
|
Thanks! I had forgotten about this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this conversation for context.