Skip to content

Conversation

@jdegoes
Copy link
Contributor

@jdegoes jdegoes commented Oct 18, 2014

Added an Enum instance for Either consistent with Either's Ord, also added jsvalidate into the mix.

Review / merge by @garyb or someone else who can merge :)

@jdegoes
Copy link
Contributor Author

jdegoes commented Oct 18, 2014

The current version of purescript-enums is 0.2.2, and as this is a fully backward-compatible patch fix, it could be released as 0.2.3.

@garyb
Copy link
Member

garyb commented Oct 18, 2014

Thanks 👍

What's the grunt-jsvalidate for in this case? I'd certainly hope the generated code is valid given there's no FFI usage! I guess it's a worthwhile addition to our gruntfiles in general though.

garyb added a commit that referenced this pull request Oct 18, 2014
@garyb garyb merged commit 990d1c6 into purescript:master Oct 18, 2014
@jdegoes
Copy link
Contributor Author

jdegoes commented Oct 18, 2014

Yeah, I just added out of policy more than anything (mental note to add to all projects I work in). I can remove it if you like. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants