Skip to content

Add blush as the opposite of hush #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Add blush as the opposite of hush #69

merged 1 commit into from
May 13, 2022

Conversation

i-am-the-slime
Copy link
Contributor

@i-am-the-slime i-am-the-slime commented May 11, 2022 •
edited
Loading

Description of the change

Adds a method blush that turns Eithers into Maybes of their possible Left values.
Often, I only care about Errors (e.g. when I have an Either Err Unit) and this function would come in handy.
Feel free to close this if you think it's a bad idea.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor

I think this should be added. I like the name as well.

JordanMartinez
JordanMartinez reviewed May 11, 2022
View reviewed changes
i-am-the-slime
i-am-the-slime commented May 13, 2022
View reviewed changes
i-am-the-slime
i-am-the-slime commented May 13, 2022
View reviewed changes
@i-am-the-slime
Add blush as an analogue to hush
c5c797c 
Also update docstring wording
JordanMartinez
JordanMartinez approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garyb Can you approve this, so we can merge it?

@JordanMartinez JordanMartinez merged commit b515c20 into purescript:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-am-the-slime @JordanMartinez @garyb