Rename duration
to diff
for Instant
#100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to make the release for #98 when I thought I'd add some test for completion's sake... and then noticed we already have this function for
Date
,Time
, andDateTime
- only it's calleddiff
for the other types. I updated this to reflect that, and fixed the example comment a little.It's perhaps debatable whether we should add
duration
for the rest and deprecatediff
instead though, since it's maybe not the best name for it - and without the record to make the start/end explicit it may not be clear which way around things should be. Although I guess the consequences of getting it wrong are "just" an inverted sign, not an incorrect magnitude at least./cc @i-am-the-slime
Also will need to add a changelog entry before I merge it this time!