[BREAKING] Iterator groupby #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instances where you want to return more than just one STArray from an STArray computation. For example, a pair of STArrays (with potentially different types), or an STArray of STArrays, or even an STArray of nonempty STArrays. The possibilities are endless! Also use unsafe-coerce instead of FFI.
Implement `groupBy` using `Data.Array.ST.Iterator`; this should make it faster.
\x y -> odd x && odd y is not an equivalence relation! It doesn't satisfy reflexivity.
|
Maybe we can do this in a non-breaking way by marking |
|
I'm going to try this in a separate branch and see how much I like it. |
Merged
|
Resolved by #89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #84 after my mistake (this requires a major release)