Skip to content

Fix pokeSTArray, some optimizations #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2015
Merged

Fix pokeSTArray, some optimizations #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ef7d45
Fix pokeSTArray, some optimizations
jacereda Mar 21, 2015
0d8fb40
Remove unsigned hints
jacereda Mar 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 16 additions & 25 deletions src/Data/Array/ST.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,34 +50,29 @@ foreign import emptySTArray """
}""" :: forall a h r. Eff (st :: ST h | r) (STArray h a)

foreign import peekSTArrayImpl """
function peekSTArrayImpl(arr, i, s, f) {
function peekSTArrayImpl(just, nothing, arr, i) {
return function() {
var index = ~~i;
if (0 <= index && index < arr.length) {
return s(arr[index]);
} else {
return f;
}
var index = i >>> 0;
return index < arr.length? just(arr[index]) : nothing;
};
}""" :: forall a h e r. Fn4 (STArray h a)
Number
(a -> r)
}""" :: forall a h e r. Fn4 (a -> r)
r
(STArray h a)
Number
(Eff (st :: ST h | e) r)

-- | Read the value at the specified index in a mutable array.
peekSTArray :: forall a h r. STArray h a -> Number -> Eff (st :: ST h | r) (Maybe a)
peekSTArray arr i = runFn4 peekSTArrayImpl arr i Just Nothing
peekSTArray = runFn4 peekSTArrayImpl Just Nothing

foreign import pokeSTArrayImpl """
function pokeSTArrayImpl(arr, i, a) {
return function() {
var index = ~~i;
if (0 <= index && index <= arr.length) {
var index = i >>> 0;
var ret = index < arr.length;
if (ret)
arr[index] = a;
return true;
}
return false;
return ret;
};
}""" :: forall a h e. Fn3 (STArray h a)
Number
Expand All @@ -86,7 +81,7 @@ foreign import pokeSTArrayImpl """

-- | Change the value at the specified index in a mutable array.
pokeSTArray :: forall a h r. STArray h a -> Number -> a -> Eff (st :: ST h | r) Boolean
pokeSTArray arr i a = runFn3 pokeSTArrayImpl arr i a
pokeSTArray = runFn3 pokeSTArrayImpl

foreign import pushAllSTArrayImpl """
function pushAllSTArrayImpl(arr, as) {
Expand Down Expand Up @@ -123,12 +118,10 @@ spliceSTArray = runFn4 spliceSTArrayImpl
foreign import copyImpl """
function copyImpl(arr) {
return function(){
var as = [];
var i = -1;
var n = arr.length;
while(++i < n) {
var as = new Array(n);
for (var i = 0; i < n; i++)
as[i] = arr[i];
}
return as;
};
}""" :: forall a b h r. a -> Eff (st :: ST h | r) b
Expand All @@ -146,12 +139,10 @@ thaw = copyImpl
foreign import toAssocArray """
function toAssocArray(arr) {
return function(){
var as = [];
var i = -1;
var n = arr.length;
while(++i < n) {
var as = new Array(n);
for (var i = 0; i < n; i++)
as[i] = {value: arr[i], index: i};
}
return as;
};
}""" :: forall a h r. STArray h a -> Eff (st :: ST h | r) [Assoc a]