Skip to content

Add groupBy to Array.NonEmpty #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

Add groupBy to Array.NonEmpty #164

merged 1 commit into from
Dec 28, 2020

Conversation

@Zelenya
Copy link
Contributor

@Zelenya Zelenya commented Jan 16, 2020 •
edited
Loading

Add groupBy, group, group' to Array.NonEmpty

@kl0tl
Copy link
Member

kl0tl commented Dec 24, 2020

We renamed group' to groupAll and also added groupAllBy in #194, we should do the same here.

@JordanMartinez JordanMartinez merged commit bdd5bd7 into purescript:master Dec 28, 2020
@JordanMartinez
Copy link
Contributor

JordanMartinez commented Dec 28, 2020

I'm going to submit a PR that addresses @kl0tl's comments.

This was referenced Dec 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zelenya @kl0tl @JordanMartinez @thomashoneyman