Skip to content

Conversation

@andys8
Copy link
Contributor

@andys8 andys8 commented Oct 11, 2020

Changes

  • affjax (slamdata/purescript-affjax) ✖ v10.1.0 -> v11.0.0

Related to #723 and #725

Update: Description heavily updated.

@andys8 andys8 force-pushed the update-19-outdated-packages branch 4 times, most recently from d2879aa to 47520a8 Compare October 11, 2020 21:30
@andys8
Copy link
Contributor Author

andys8 commented Oct 11, 2020

It looks like updating purescript-affjax will break purescript-simple-ajax.

I don't know how this is handled in general.
I provided a fix dariooddenino/purescript-simple-ajax#6

Compiling Sijidou
[info] Build succeeded.
[info] Successfully verified "sijidou"
[info] Installing 1 dependencies.
[info] Searching for packages cache metadata..
[info] Recent packages cache metadata found, using it..
[info] Installing "simple-ajax"
[info] Installation complete.
[info] Verifying package "simple-ajax"
Error found:
in module Simple.Ajax
at .spago/simple-ajax/v2.0.0/src/Simple/Ajax.purs:109:24 - 111:38 (line 109, column 24 - line 111, column 38)

  Could not match type

    ( timeout :: Maybe Milliseconds
    ...
    )

  with type

    ( ... )


while trying to match type
                             ( timeout :: Maybe Milliseconds
                             ...
                             )

  with type
              ( ... )

while solving type class constraint

  Prim.Row.Nub t0
               ( content :: Maybe RequestBody
               , headers :: Array RequestHeader
               , method :: Either Method CustomMethod
               , password :: Maybe String
               , responseFormat :: ResponseFormat String
               , url :: String
               , username :: Maybe String
               , withCredentials :: Boolean
               )

while inferring the type of merge { responseFormat: string
                                  , headers: [ ...
                                             ]
                                  }
in value declaration defaultSimpleRequest

where t0 is an unknown type

See https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md for more information,
Compiling Simple.Ajax.Errors
Compiling Simple.Ajax
or to contribute content related to this error.


[error] Failed to build.

andys8 added a commit to andys8/package-sets that referenced this pull request Oct 11, 2020
- ace (purescript-contrib/purescript-ace) ✖ v7.0.0 -> v7.1.0
- arraybuffer-class (athanclark/purescript-arraybuffer-class) ✖ v0.2.5 -> v0.2.6
- checked-exceptions (natefaubion/purescript-checked-exceptions) ✖ v3.1.0 -> v3.1.1
- codec (garyb/purescript-codec) ✖ v3.0.0 -> v3.1.0
- debug (garyb/purescript-debug) ✖ v4.0.0 -> v4.0.1
- halogen (slamdata/purescript-halogen) ✖ v5.0.1 -> v5.1.0
- halogen-formless (thomashoneyman/purescript-halogen-formless) ✖ v1.0.0-rc.2 -> v1.0.0
- halogen-hooks (thomashoneyman/purescript-halogen-hooks) ✖ v0.4.2 -> v0.4.3
- halogen-svg-elems (JordanMartinez/purescript-halogen-svg-elems) ✖ v2.0.1 -> v2.0.2
- heckin (maxdeviant/purescript-heckin) ✖ v1.0.3 -> v1.1.0
- hyper (purescript-hyper/hyper) ✖ v0.11.0 -> v0.11.1
- npm-package-json (maxdeviant/purescript-npm-package-json) ✖ v1.1.0 -> v1.2.0
- option (joneshf/purescript-option) ✖ v6.0.0 -> v6.0.1
- parsing (purescript-contrib/purescript-parsing) ✖ v5.0.3 -> v5.1.0
- payload (hoodunit/purescript-payload) ✖ v0.3.0 -> v0.3.1
- react-basic-hooks (spicydonuts/purescript-react-basic-hooks) ✖ v6.1.1 -> v6.2.0
- strings-extra (purescript-contrib/purescript-strings-extra) ✖ v2.1.0 -> v2.2.1
- unsafe-reference (purescript-contrib/purescript-unsafe-reference) ✖ v3.0.1 -> v3.1.0

affjax is not updated, see
<purescript#724 (comment)>

Solves #723
@andys8
Copy link
Contributor Author

andys8 commented Oct 11, 2020

I'd suggest considering this blocked, and proceed with #725

@andys8 andys8 marked this pull request as draft October 11, 2020 22:08
JordanMartinez pushed a commit that referenced this pull request Oct 11, 2020
- ace (purescript-contrib/purescript-ace) ✖ v7.0.0 -> v7.1.0
- arraybuffer-class (athanclark/purescript-arraybuffer-class) ✖ v0.2.5 -> v0.2.6
- checked-exceptions (natefaubion/purescript-checked-exceptions) ✖ v3.1.0 -> v3.1.1
- codec (garyb/purescript-codec) ✖ v3.0.0 -> v3.1.0
- debug (garyb/purescript-debug) ✖ v4.0.0 -> v4.0.1
- halogen (slamdata/purescript-halogen) ✖ v5.0.1 -> v5.1.0
- halogen-formless (thomashoneyman/purescript-halogen-formless) ✖ v1.0.0-rc.2 -> v1.0.0
- halogen-hooks (thomashoneyman/purescript-halogen-hooks) ✖ v0.4.2 -> v0.4.3
- halogen-svg-elems (JordanMartinez/purescript-halogen-svg-elems) ✖ v2.0.1 -> v2.0.2
- heckin (maxdeviant/purescript-heckin) ✖ v1.0.3 -> v1.1.0
- hyper (purescript-hyper/hyper) ✖ v0.11.0 -> v0.11.1
- npm-package-json (maxdeviant/purescript-npm-package-json) ✖ v1.1.0 -> v1.2.0
- option (joneshf/purescript-option) ✖ v6.0.0 -> v6.0.1
- parsing (purescript-contrib/purescript-parsing) ✖ v5.0.3 -> v5.1.0
- payload (hoodunit/purescript-payload) ✖ v0.3.0 -> v0.3.1
- react-basic-hooks (spicydonuts/purescript-react-basic-hooks) ✖ v6.1.1 -> v6.2.0
- strings-extra (purescript-contrib/purescript-strings-extra) ✖ v2.1.0 -> v2.2.1
- unsafe-reference (purescript-contrib/purescript-unsafe-reference) ✖ v3.0.1 -> v3.1.0

affjax is not updated, see
<#724 (comment)>

Solves #723
@andys8 andys8 force-pushed the update-19-outdated-packages branch from 47520a8 to 0e42e6a Compare October 11, 2020 22:17
@andys8
Copy link
Contributor Author

andys8 commented Oct 11, 2020

Rebased on master because #725 was merged

@andys8 andys8 changed the title Update 19 outdated versions Update affjax to 11.0.0 Oct 11, 2020
@JordanMartinez
Copy link
Contributor

I'm guessing this should be considered blocked until simple-ajax is updated?

@andys8
Copy link
Contributor Author

andys8 commented Oct 11, 2020

Yes

@thomashoneyman
Copy link
Member

In general we try to let package authors have 2 weeks to respond before their package is dropped from the set due to a breaking change in a dependency, unless that dependency change will affect a lot of libraries, in which case we allow for longer.

@dariooddenino
Copy link
Contributor

I have merged the pr and published a new version of simple-ajax. Let me know if I have to do anything else, thanks! :)

@andys8 andys8 marked this pull request as ready for review October 13, 2020 09:55
@andys8
Copy link
Contributor Author

andys8 commented Oct 13, 2020

Thanks for the quick response @dariooddenino

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👏

@f-f f-f merged commit 9c73230 into purescript:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants