package-set-0.12 #171
package-set-0.12 #171
Conversation
|
Will probably need to remove all non-core packages. |
|
Should add this as a branch first? like 0.12-rc or something edit: I don't know if GitHub UI actually allows for PRs that create a branch 😄 |
|
Yeah you'll need to create a new branch in this repo and then update this PR to switch base branch. |
chexxor
force-pushed
the
package-set-0.12
branch
from
2e4fe0e to
8eed61e
Compare
|
Will eventually need to update travis.yml to point at the 0.12-rc compiler release once that is available. |
|
Could you reset the commit and force push it? Travis seems to not understand how to use the correct commit. |
packages.json
Outdated
| @@ -1257,21 +1235,12 @@ | |||
| "repo": "https://github.com/Thimoteus/purescript-mmorph.git", | |||
| "version": "v3.0.0" | |||
| }, | |||
| "monoid": { | |||
There was a problem hiding this comment.
The type class has moved to Prelude.
There was a problem hiding this comment.
Ah, then all the listings of dependencies should be removed. Cool
There was a problem hiding this comment.
|
In addition, reverse dependencies of typelevel-prelude won't work without upgrades themselves, so they need to be removed. E.g. Simple-JSON |
|
Yeah, I'll work on that. |
|
I just removed all non-core libs. Can re-add other libs as they get upgraded to work with new core libs. |
chexxor
force-pushed
the
package-set-0.12
branch
from
c42210a to
9fa9d35
Compare
|
Requires some PRs be merged in some libs: |
|
Removed "inject" package, as that'll be merged into functors/either. purescript-deprecated/purescript-inject#10 |
|
Exceptions needs an update or a new target? |
|
Oh, builds locally just fine... edit: oh, it's probably that the Travis cache messes it up. Builds just fine without cache, so merging this into the branch. https://travis-ci.org/justinwoo/package-sets/builds/373085891 Thanks!! |
|
Yeah I suspected of was a caching issue in CI, which seems hard to debug so
I gave up to look again at a later time when I have more fortitude.
…On Mon, Apr 30, 2018, 10:24 AM Justin Woo ***@***.***> wrote:
Oh, builds locally just fine...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzdmaKN3wkxrVLVLx3LdJRIhAZpw73tks5ttyyugaJpZM4Trk5Z>
.
|
This adds the SHAs for the core packages (those in the purescript org), from this list: purescript/purescript#3116
I need to figure out how to verify this package.json file - it looks like
psc-package verifyexpects a psc-package.json file...Until then, though, I welcome reviews.