Note annotation requirements in let and where#350
Open
milesfrain wants to merge 1 commit intopurescript:masterfrom
Open
Note annotation requirements in let and where#350milesfrain wants to merge 1 commit intopurescript:masterfrom
milesfrain wants to merge 1 commit intopurescript:masterfrom
Conversation
Inspired by purescript/purescript#3922 This might be too nitty-gritty for initial reference, but I think this should be documented _somewhere_. If these details exist in another location, it should at least be discoverable from the `let`/`where` reference section.
Collaborator
|
I think the language reference is the correct place to note this, but this isn’t to do with syntax, so I don’t think it should go in the Syntax.md file. |
Contributor
|
This PR hasn't been merged because this PR is somewhat incorrect. The annotation is only needed when the same function is used at least twice and each usage takes an argument of a different type, such that the function must be polymorphic. Those rules aren't actually clarified in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by purescript/purescript#3922
This might be too nitty-gritty for initial reference, but I think this should be documented somewhere. If these details exist in another location, it should at least be discoverable from the
let/wherereference section.