Do not pass filename == null to FileData.append
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
changed the title
filename == null to FileData.append
JordanMartinez
approved these changes
Feb 22, 2023
|
Are there some additional steps I need to take to have this merged? |
|
Sorry, I've had a busy few weeks! |
garyb
approved these changes
Mar 17, 2023
|
No worries @garyb, thank you for merging! |
|
Just remembered to make a release for this! It's out as v5.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When calling
appendBloborsetBlob, passingNothingfor thefilenameparameter translates into callingfd.append(_, _, null), which has the effect of setting filename to"null"(at least on Chromium and FireFox), rather than the intended behavior of getting the filename from theFileobject.This change makes it so that
Nothingon PureScript side translates toundefinedon JS side, which works as expected.Checklist:
[ ] Linked any existing issues or proposals that this pull request should close[ ] Updated or added relevant documentation[ ] Added a test for the contribution (if applicable)