Skip to content

update for purs 0.13 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update for purs 0.13 #95

wants to merge 1 commit into from

Conversation

@justinwoo
Copy link
Contributor

@justinwoo justinwoo commented May 30, 2019

No description provided.

@hdgarrood
Copy link
Contributor

hdgarrood commented May 30, 2019

I don't think we should tighten all of these lower bounds; the code isn't changing so I don't think there's any reason to suspect react-basic will stop working with older versions of these libraries. I think we should leave all of the version ranges alone apart from web-dom, web-html and web-events, and I think those three can use a >=1.0.0 <3.0.0 range.

@hdgarrood
Copy link
Contributor

hdgarrood commented May 30, 2019

Oh I guess record needs to relax its upper bound too; >=1.0.0 <3.0.0 should work there as well.

@justinwoo
Copy link
Contributor Author

justinwoo commented May 30, 2019

I only just now realized I didn't change any source files in this branch, so I didn't need to make this PR. sorry

@justinwoo justinwoo closed this May 30, 2019
@hdgarrood hdgarrood mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinwoo @hdgarrood