Skip to content

Fix module-level reference to "window" #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Fix module-level reference to "window" #85

merged 1 commit into from
Mar 15, 2019

Conversation

@maddie927
Copy link
Member

A module-level window reference prevents the use of this library in server- and static-rendering.

@maddie927 maddie927 self-assigned this Mar 12, 2019
@maddie927 maddie927 merged commit 5764f18 into master Mar 15, 2019
@maddie927 maddie927 deleted the madeline/fix-window-reference branch March 15, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hdgarrood hdgarrood hdgarrood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maddie927 maddie927

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maddie927 @hdgarrood