Skip to content

Add roles declarations to allow safe coercions #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: ps-0.14
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update library to compile on upcoming 0.14.0 PS release (#113)
  • Loading branch information
JordanMartinez authored Feb 24, 2020
commit 477b9cfd417bfd37ee3293593cd7e725f656d9b8
2 changes: 1 addition & 1 deletion src/React/Basic.purs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ foreign import createComponent
-- | identify the component. It receives the `ComponentSpec` as a prop and knows
-- | how to defer behavior to it. It requires very specific props and is not useful by
-- | itself from JavaScript. For JavaScript interop, see `toReactComponent`.__
data Component props
foreign import data Component :: Type -> Type

-- | `Self` represents the component instance at a particular point in time.
-- |
Expand Down
4 changes: 2 additions & 2 deletions src/React/Basic/Events.purs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Data.Symbol (class IsSymbol, SProxy(SProxy))
import Effect (Effect)
import Effect.Uncurried (EffectFn1, mkEffectFn1)
import Prim.Row as Row
import Prim.RowList (kind RowList, class RowToList, Cons, Nil)
import Prim.RowList (class RowToList, RowList, Cons, Nil)
import Record (delete, get, insert)
import Type.Data.RowList (RLProxy(..))

Expand Down Expand Up @@ -77,7 +77,7 @@ handler_ = mkEffectFn1 <<< const
syntheticEvent :: EventFn SyntheticEvent SyntheticEvent
syntheticEvent = identity

class Merge (rl :: RowList) fns a r | rl -> fns, rl a -> r where
class Merge (rl :: RowList Type) fns a r | rl -> fns, rl a -> r where
mergeImpl :: RLProxy rl -> Record fns -> EventFn a (Record r)

instance mergeNil :: Merge Nil () a () where
Expand Down