Skip to content

Add onFinish event #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2017
Merged

Add onFinish event #14

merged 1 commit into from
Apr 20, 2017

Conversation

felixSchl
Copy link
Contributor

Required to get notified when a pipe finishes

@hdgarrood
Copy link
Member

Judging by the node api docs, shouldn't this be for writable streams?

@felixSchl
Copy link
Contributor Author

Good catch!

hdgarrood
hdgarrood approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@paf31 paf31 merged commit 2ebad3f into purescript-node:master Apr 20, 2017
@paf31
Copy link
Contributor

paf31 commented Apr 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixSchl @hdgarrood @paf31