Skip to content

Update to PureScript v0.15.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sigma-andex
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@sigma-andex
Copy link
Contributor Author

🏓 @JordanMartinez

Co-authored-by: Thomas Honeyman <hello@thomashoneyman.com>
@thomashoneyman
Copy link
Contributor

Let's hold off merging until we make a decision wrt which Node version to support and whether we'll allow arrow functions.

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a changelog entry update here, too.

src/Node/Path.js Outdated
};
};
export function resolve(from) {
return to => (function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

return to => {
  return () => {
  };
];

@JordanMartinez JordanMartinez merged commit a8ba2e5 into purescript-node:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants