Use proper types for HTMLform properties #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natefaubion this really is a breaking change, I guess we'll have to bump Halogen to v2.0 too 😕 I did a quick scan through to see if there were any other obvious stringly-typed properties that shouldn't be, but didn't see any. Maybe you could have a look through too to double check? |
|
I would not consider this a breaking change, as it was unusable before. This is correcting the definition. |
|
Fair enough, I did consider that argument also. Could breaking-bump this and then patch-bump Halogen perhaps? That way at least if anyone else is depending on this they'll know about the conflict at "dependency time". |
|
I'm fine with that. |
natefaubion
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve purescript-halogen/purescript-halogen#433