This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Fix setTextContent type and FFI code #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh, thanks! |
garyb
added a commit
that referenced
this pull request
Aug 25, 2015
Fix setTextContent type and FFI code
|
I don't really need this urgently, but maybe it would be useful to release a new version with this fix? If I remember correctly, you wanted to hold back, in case other things would pop up.. but so far, nothing did. |
|
Sorry I totally forgot about this! |
|
No problem, Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overlooked this in the last PR. The type of
setTextContentwas still wrong. It's implementation too 😄