Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Fix types of setId, setClassName, setAttribute and setTextContent #19

Merged
merged 1 commit into from
Aug 23, 2015
Merged

Fix types of setId, setClassName, setAttribute and setTextContent #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/DOM/Node/Element.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ id :: forall eff. Element -> Eff (dom :: DOM | eff) ElementId
#### `setId`

``` purescript
setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) ElementId
setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) Unit
```

#### `className`
Expand All @@ -45,7 +45,7 @@ className :: forall eff. Element -> Eff (dom :: DOM | eff) String
#### `setClassName`

``` purescript
setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) String
setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) Unit
```

#### `getElementsByTagName`
Expand All @@ -69,7 +69,7 @@ getElementsByClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff
#### `setAttribute`

``` purescript
setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) String
setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) Unit
```

#### `getAttribute`
Expand Down
2 changes: 1 addition & 1 deletion docs/DOM/Node/Node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ cases.
#### `setTextContent`

``` purescript
setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) Unit
```

If the node type is document fragment, element, text, processing
Expand Down
8 changes: 5 additions & 3 deletions src/DOM/Node/Element.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module DOM.Node.Element where

import Prelude (Unit())

import Control.Monad.Eff (Eff())

import Data.Nullable (Nullable())
Expand All @@ -13,13 +15,13 @@ foreign import localName :: Element -> String
foreign import tagName :: Element -> String

foreign import id :: forall eff. Element -> Eff (dom :: DOM | eff) ElementId
foreign import setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) ElementId
foreign import setId :: forall eff. ElementId -> Element -> Eff (dom :: DOM | eff) Unit
foreign import className :: forall eff. Element -> Eff (dom :: DOM | eff) String
foreign import setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) String
foreign import setClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) Unit

foreign import getElementsByTagName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) HTMLCollection
foreign import getElementsByTagNameNS :: forall eff. Nullable String -> String -> Element -> Eff (dom :: DOM | eff) HTMLCollection
foreign import getElementsByClassName :: forall eff. String -> Element -> Eff (dom :: DOM | eff) HTMLCollection

foreign import setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) String
foreign import setAttribute :: forall eff. String -> String -> Element -> Eff (dom :: DOM | eff) Unit
foreign import getAttribute :: forall eff. String -> Element -> Eff (dom :: DOM | eff) (Nullable String)
2 changes: 1 addition & 1 deletion src/DOM/Node/Node.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ foreign import textContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
-- | If the node type is document fragment, element, text, processing
-- | instruction, or comment this allows the node's data to be changed, or has
-- | no effect in all other cases.
foreign import setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) String
foreign import setTextContent :: forall eff. Node -> Eff (dom :: DOM | eff) Unit

-- | Removes empty text nodes and then combines any remaining text nodes that
-- | are contiguous.
Expand Down