Skip to content

Lens version change #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Lens version change #46

merged 3 commits into from
Feb 7, 2019

Conversation

athanclark
Copy link
Contributor

Just a simple hard version change on profunctor-lenses, so argonaut-traversals doesn't cause a version conflict.

@garyb
Copy link
Member

garyb commented Jan 26, 2019

Maybe we can use a range here so this can be a non-breaking change? Not sure if that works, but worth a try perhaps.

@athanclark
Copy link
Contributor Author

Ahh totally, I just reviewed the changes to profunctor-lenses, and it's not major. One sec!

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2019

CLA assistant check
All committers have signed the CLA.

@garyb
Copy link
Member

garyb commented Jan 26, 2019

I think maybe >= 4.0.0 <6.0.0 would do it? The current one seems to match everything above v4 (according to https://jubianchi.github.io/semver-check at least)

@athanclark
Copy link
Contributor Author

Sorry ><

@garyb
Copy link
Member

garyb commented Jan 28, 2019

Shouldn't it be <6.0.0, since we want it to be compatible with 5.x.y? 😁

@athanclark
Copy link
Contributor Author

I'm gonna have to blame the economy on this one. Sorry, one sec again

@garyb
Copy link
Member

garyb commented Feb 7, 2019

Thanks!

@garyb garyb merged commit 070d3d6 into purescript-contrib:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants