Fix behaviour of semicolons in query parts #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were decoding percent encoded aspects of the query string before doing the splitting on `&` and `;` delimiters, meaning it was impossible to determine where a split actually was, as we lost the information about which characters had been encoded or not.
|
@cryogenian can you try this locally to see if it fixes the issues you were having, without the other workarounds you had to impose? |
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27, resolves #28
We were decoding percent encoded aspects of the query string before doing the splitting on
∧delimiters, meaning it was impossible to determine where a split actually was, as we lost the information about which characters had been encoded or not.Also printing was incorrect.