Parsing a host that starts with a number

[ethul]

When parsing a URI with a host that starts with a number; e.g., https://1a.test.com, the parser fails with the error Could not match character '.'. I believe the parser is attempting to parse it as an IP address and failing:

https://github.com/slamdata/purescript-uri/blob/5600a0addaed38688e381f5b96d7f7a870dd88e5/src/Data/URI/Host.purs#L39

If it helps, I noticed the parsing error when upgrading from version 2.0.0 to version 2.0.1. The issue is still present on verson 4.2.2

[garyb]

Yeah I think you've identified the exact problem with that line! I think it should be more like:

parser = try ipv6AddressParser <|> try ipv4AddressParser <|> regNameParser

[ethul]

Makes sense. Thanks for taking a look!

…

On Wed, Jan 3, 2018 at 19:19 Gary Burgess ***@***.***> wrote: Yeah I think you've identified the exact problem with that line! I think it should be more like: parser = try ipv6AddressParser <|> try ipv4AddressParser <|> regNameParser — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYyyPRNMigme9Dw_S_yc0kmYKbO5FLks5tHBkCgaJpZM4RSZzX> .

[ethul]

Thanks!

…

On Wed, Jan 3, 2018 at 19:34 Gary Burgess ***@***.***> wrote: Closed #39 <#39> via #40 <#40>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYy-SNuK3uT65W7LROTwR_95102ixjks5tHBx9gaJpZM4RSZzX> .