Stack safety (#65)

* Ignore node_modules

* Add test that causes a stack overflow

* Use stack safe `many`/`some`

* Update CHANGELOG.md

* Add explicit lists dependency

Author: garyb

.gitignore

@@ -6,3 +6,4 @@
 output
 generated-docs
 bower_components
+node_modules

CHANGELOG.md

@@ -9,6 +9,7 @@ Breaking changes:
 New features:
 
 Bugfixes:
+- Made all parsers stack safe on long input (#63 by @garyb)
 
 Other improvements:
 

spago.dhall

@@ -13,6 +13,7 @@
   , "gen"
   , "integers"
   , "js-uri"
+  , "lists"
   , "maybe"
   , "newtype"
   , "parsing"

src/URI/Common.purs

@@ -17,17 +17,16 @@ import Prelude
 import Control.Alt ((<|>))
 import Control.Monad.Except (throwError)
 import Control.Monad.State (get)
-import Data.Array as Array
 import Data.Either (Either(..), either)
 import Data.Generic.Rep (class Generic)
+import Data.List as List
 import Data.Maybe (fromJust)
 import Data.Newtype (class Newtype, un)
 import Data.Show.Generic (genericShow)
-import Data.String (joinWith) as String
 import Data.String.CodeUnits (singleton) as String
 import Data.String.NonEmpty (NonEmptyString)
+import Data.String.NonEmpty (joinWith, toString, unsafeFromString) as NES
 import Data.String.NonEmpty.CodeUnits (singleton) as NES
-import Data.String.NonEmpty (unsafeFromString, toString) as NES
 import JSURI (decodeURIComponent, encodeURIComponent)
 import Partial.Unsafe (unsafePartial)
 import Text.Parsing.Parser (ParseError(..), ParseState(..), Parser, ParserT(..), runParser)
@@ -93,11 +92,11 @@ printEncoded ∷ Parser String Char → String → String
 printEncoded p s = either (const s) identity (runParser s parse)
   where
     parse ∷ Parser String String
-    parse = (String.joinWith "" <$> Array.many (simpleChar <|> encodedChar)) <* eof
-    simpleChar ∷ Parser String String
-    simpleChar = String.singleton <$> p
-    encodedChar ∷ Parser String String
-    encodedChar = unsafePartial fromJust <<< encodeURIComponent <<< String.singleton <$> anyChar
+    parse = (NES.joinWith "" <$> List.manyRec (simpleChar <|> encodedChar)) <* eof
+    simpleChar ∷ Parser String NonEmptyString
+    simpleChar = NES.singleton <$> p
+    encodedChar ∷ Parser String NonEmptyString
+    encodedChar = unsafePartial (NES.unsafeFromString <<< fromJust) <<< encodeURIComponent <<< String.singleton <$> anyChar
 
 -- | A version of [`printEncoded`](#v:printEncoded) that operates on non-empty
 -- | strings.

src/URI/Extra/QueryPairs.purs

@@ -23,6 +23,7 @@ import Data.Array as Array
 import Data.Bifunctor (bimap)
 import Data.Either (Either)
 import Data.Generic.Rep (class Generic)
+import Data.List as List
 import Data.Maybe (Maybe(..), fromJust)
 import Data.Show.Generic (genericShow)
 import Data.String as String
@@ -78,10 +79,10 @@ parsePart
   → Parser String (Tuple k (Maybe v))
 parsePart parseK parseV = do
   key ← wrapParser (parseK <<< Key) $
-    NES.joinWith "" <$> Array.some (NES.singleton <$> keyPartChar <|> pctEncoded)
+    NES.joinWith "" <$> List.someRec (NES.singleton <$> keyPartChar <|> pctEncoded)
   value ← wrapParser (traverse (parseV <<< Value)) $ optionMaybe do
     _ ← char '='
-    NES.joinWith "" <$> Array.many (NES.singleton <$> valuePartChar <|> pctEncoded)
+    NES.joinWith "" <$> List.manyRec (NES.singleton <$> valuePartChar <|> pctEncoded)
   pure $ Tuple key value
 
 -- | A printer for key/value pairs style query string.

src/URI/Fragment.purs

@@ -12,10 +12,10 @@ module URI.Fragment
 import Prelude
 
 import Control.Alt ((<|>))
-import Data.Array as Array
+import Data.List as List
 import Data.Maybe (fromJust)
-import Data.String.NonEmpty.CodeUnits (singleton) as NES
 import Data.String.NonEmpty (joinWith) as NES
+import Data.String.NonEmpty.CodeUnits (singleton) as NES
 import JSURI (decodeURIComponent)
 import Partial.Unsafe (unsafePartial)
 import Text.Parsing.Parser (Parser)
@@ -75,7 +75,7 @@ parser ∷ Parser String Fragment
 parser =
   char '#' *>
     (Fragment <<< NES.joinWith ""
-      <$> Array.many (pctEncoded <|> NES.singleton <$> fragmentChar))
+      <$> List.manyRec (pctEncoded <|> NES.singleton <$> fragmentChar))
 
 -- | A printer for the fragment component of a URI. Will print the value with
 -- | a `'#'` prefix.

src/URI/Host/IPv6Address.purs

@@ -8,8 +8,9 @@ module URI.Host.IPv6Address
 import Prelude
 
 import Control.Alt ((<|>))
-import Data.Array as Array
-import Data.String.CodeUnits as String
+import Data.List as List
+import Data.String.NonEmpty as NES
+import Data.String.NonEmpty.CodeUnits as NESCU
 import Text.Parsing.Parser (Parser)
 import Text.Parsing.Parser.Combinators ((<?>))
 import Text.Parsing.Parser.String (char)
@@ -34,7 +35,7 @@ unsafeToString (IPv6Address s) = "[" <> s <> "]"
 parser ∷ Parser String IPv6Address
 parser =
   IPv6Address
-    <$> (char '[' *> (String.fromCharArray <$> Array.some ipv6Char) <* char ']')
+    <$> (char '[' *> (NES.joinWith "" <$> List.someRec (NESCU.singleton <$> ipv6Char)) <* char ']')
     <?> "IPv6 address"
   where
     ipv6Char ∷ Parser String Char

src/URI/Path.purs

@@ -4,6 +4,7 @@ import Prelude
 
 import Data.Array as Array
 import Data.Generic.Rep (class Generic)
+import Data.List as List
 import Data.Show.Generic (genericShow)
 import Data.String as String
 import Text.Parsing.Parser (Parser)
@@ -26,7 +27,7 @@ instance showPath ∷ Show Path where show = genericShow
 
 -- | A parser for a _path-abempty_ URI component.
 parser ∷ Parser String Path
-parser = Path <$> Array.many (char '/' *> parseSegment)
+parser = Path <<< Array.fromFoldable <$> List.manyRec (char '/' *> parseSegment)
 
 -- | A printer for a _path-abempty_ URI component.
 print ∷ Path → String

src/URI/Path/Absolute.purs

@@ -4,6 +4,7 @@ import Prelude
 
 import Data.Array as Array
 import Data.Generic.Rep (class Generic)
+import Data.List as List
 import Data.Maybe (Maybe(..))
 import Data.Show.Generic (genericShow)
 import Data.String as String
@@ -36,7 +37,11 @@ parse = do
   _ ← char '/'
   optionMaybe parseSegmentNZ >>= case _ of
     Just head →
-      PathAbsolute <<< Just <<< Tuple head <$> Array.many (char '/' *> parseSegment)
+      PathAbsolute
+        <<< Just
+        <<< Tuple head
+        <<< Array.fromFoldable
+        <$> List.manyRec (char '/' *> parseSegment)
     Nothing →
       pure (PathAbsolute Nothing)
 

src/URI/Path/NoScheme.purs

@@ -4,6 +4,7 @@ import Prelude
 
 import Data.Array as Array
 import Data.Generic.Rep (class Generic)
+import Data.List as List
 import Data.Show.Generic (genericShow)
 import Data.String as String
 import Data.Tuple (Tuple(..))
@@ -27,8 +28,8 @@ instance showPathNoScheme ∷ Show PathNoScheme where show = genericShow
 parse ∷ Parser String PathNoScheme
 parse = do
   head ← parseSegmentNZNC
-  tail ← Array.many (char '/' *> parseSegment)
-  pure (PathNoScheme (Tuple head tail))
+  tail ← List.manyRec (char '/' *> parseSegment)
+  pure (PathNoScheme (Tuple head (Array.fromFoldable tail)))
 
 -- | A printer for a _path-noscheme_ URI component.
 print ∷ PathNoScheme → String