Skip to content

Stack safety #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2021
Merged

Stack safety #65

merged 5 commits into from
Oct 4, 2021

Conversation

garyb
Copy link
Member

@garyb garyb commented Oct 3, 2021

Description of the change

Replaces the non-stack safe many/some usages with manyRec and someRec. These only apply to lists, so there's some conversions involved post-parse now, or it's updated to use NonEmptyStrings since there's a "container"-agnostic joinWith for that.

Resolves #63, resolves #62

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@thomashoneyman thomashoneyman merged commit b5ba408 into main Oct 4, 2021
@thomashoneyman thomashoneyman deleted the stack-safety branch October 4, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query parsing is not stack safe
2 participants
@garyb @thomashoneyman