Skip to content

Compiler/0.12 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2018
Merged

Compiler/0.12 #41

merged 8 commits into from
May 31, 2018

Conversation

kritzcreek
Copy link
Contributor

No description provided.

@kritzcreek
Copy link
Contributor Author

Fixes #36, @newlandsvalley Could you check if I got all the combinators that should return NELs in 19bc664?

@newlandsvalley
Copy link
Contributor

OK - I'll take a look.

@newlandsvalley
Copy link
Contributor

As far as I can tell, only sepBy1 is missing. Also, I think that the doc comments on endBy and endBy1 should be swapped over.

@kritzcreek
Copy link
Contributor Author

Good catch! Thanks :)

@newlandsvalley
Copy link
Contributor

Many thanks for fixing this, @kritzcreek .

@kritzcreek
Copy link
Contributor Author

You're welcome :) Thanks for taking a look

@kritzcreek kritzcreek merged commit 7f75409 into master May 31, 2018
@kritzcreek kritzcreek deleted the compiler/0.12 branch May 31, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants