Use MonadRec for many #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, but should this go in |
|
Oh right, we already have it there. In that case I'll drop it and add a re-export instead. |
paf31
reviewed
Oct 28, 2016
| go :: List a -> Parser (Step (List a) (List a)) | ||
| go acc = do | ||
| aa <- (Loop <$> p) <|> pure (Done unit) | ||
| pure $ bimap (flip Cons acc) (\_ -> reverse acc) aa |
|
True, but the version in |
|
How's this? |
|
Looks great! |
|
Nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #21 (thanks @nwolverson!)
Resolves #21, resolves #9.