Introduce purs-tidy formatter #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
approved these changes
Nov 17, 2021
src/Routing/Match/Error.purs
Outdated
| | KeyNotFound String | ||
| -- custom fail | ||
| -- custom fail |
There was a problem hiding this comment.
It seems like these are meant to be doc comments before they were supported at the constructor level. Should we add them here while we're at it?
There was a problem hiding this comment.
IMO we should remove these comments altogether, because the constructors themselves appear to tell you as much as the comments do (like expected end as a comment for the ExpectedEnd constructor)
src/Routing/Parser.purs
Outdated
| pathParts str = | ||
| let | ||
| parts = L.fromFoldable $ map (Path <<< decoder) (S.split (S.Pattern "/") str) | ||
| in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Introduces the
purs-tidyformatter. This formatter is a lightly opinionated tool we use to maintain a consistent style in the contrib libraries.We ordinarily restrict to tools provided by the
coreorcontribprojects. This tool is not, but it was developed and is maintained by core team members, and because it's a formatter it can't block maintenance or release of this library even in the event something goes catastrophically wrong with it.Checklist: